On Tue, Dec 15, 2015 at 11:48 AM, NGie Cooper <yaneurab...@gmail.com> wrote:
> > > On Dec 15, 2015, at 03:24, Andrey V. Elsukov <a...@freebsd.org> wrote: > > > > On 14.12.15 19:58, Mariusz Zaborski wrote: > >> On Mon, Dec 14, 2015 at 07:55:06PM +0300, Andrey V. Elsukov wrote: > >>> On 14.12.15 19:51, Mariusz Zaborski wrote: > >>>> On Mon, Dec 14, 2015 at 06:31:52AM -0800, NGie Cooper wrote: > >>>>> Hi Andrey, Just a heads up that LINT-NOINET seems to be broken on > >>>>> amd64/i386 with if_gif(4) on stable/10. Could you please fix this? > >>>>> Thanks, -NGie > >>>> Hi, > >>>> > >>>> I already found the problem we need to MFC r276224 and r277130. > >>> > >>> I don't think r277130 is related to this problem. > >>> I have this patch and I'm trying to build with them. > >> Not with this but after fixing r276224 it will crash in other place > which > >> r277130 is fixing. :) > > > > Actually, I don't think that my patch will work correctly. > > opt_inet.h can contain several options in addition to INET. In such case > > the expression > > > > OPT_INET!= cat ${KERNBUILDDIR}/opt_inet.h; echo > > .if empty(OPT_INET) > > > > will always be true. Are you sure merging of r276224 it works as > expected? > > > > Probably, this patch will work correctly: > > Would it be a good idea to do: > > MK_INET_SUPPORT?=no > > instead of: > > MK_INET_SUPPORT=no > > , in the event that someone wanted if_gif support but hadn’t configured > their kernel yet? > No. If your kernel doesn't have INET support, but the if_gif module does, then it won't load. Warner _______________________________________________ freebsd-stable@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-stable To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"