on 01/09/2013 23:40 Adrian Chadd said the following: > On 31 August 2013 23:41, Andriy Gapon <a...@freebsd.org > <mailto:a...@freebsd.org>> > wrote: > > > > > I've tracked this down to a single line, details in > > http://www.freebsd.org/cgi/query-pr.cgi?pr=181632. Basically, the > code is > > now doing a 'sti, hlt' vs. a 'sti' in some code that is only > supposed > to run > > if idle is disabled. Given that 'hlt' is the idle instruction, this > doesn't > > seem right. > > > > > > Wow, nice! > > > > Avg - can we get this fixed? Or just revert this! > > Thank you for trying to be helpful. But let's not jump to conclusions. > BTW, I am following up on the problem in the PR. > > > Sure, I'd like to know why it's behaving badly. But since we're so close to > 9.2-REL, do you think you can get it sorted out and bug-free on all the > existing > platforms that people are using 9.2 on (including server, desktop and laptop) > without reverting it?
Do you have any evidence that there is anybody else besides Mike who has this problem? Also, I usually try to "sort out" things after there is a clear understanding of what the problem is and how it should be fixed. > Reverting and fixing it later seems like the safest option to me. Is there a > bigger problem that you tried to fix in that patch that wasn't as obvious? I do not see any problem with the code*.* I do not see any explanation of the root cause of the problem that Mike has. I do not see why anything has to be reverted. Especially because "since we're so close to 9.2-REL". Just in case, I'll remind that the commit in question is in stable/9 since Dec 23 2012. -- Andriy Gapon _______________________________________________ freebsd-stable@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-stable To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"