On 09/18/2012 08:45, John-Mark Gurney wrote:
> Chris Rees wrote this message on Tue, Sep 18, 2012 at 16:37 +0100:
>> On 18 Sep 2012 16:28, "John-Mark Gurney" <[email protected]> wrote:
>>>
>>> Any objections?
>>>
>>> This makes it explicate that these controls are dependant upon AC
>>> online/offline state...
I like the idea of clarifying, but I don't think this helps enough. Can
you instead add a newline and a comment on its own line above
performance_cx_lowest with a little more detail?
> Ugh, sorry:
> Index: etc/defaults/rc.conf
> ===================================================================
> --- etc/defaults/rc.conf (revision 240566)
> +++ etc/defaults/rc.conf (working copy)
> @@ -654,10 +654,10 @@
> devfs_set_rulesets="" # A list of /mount/dev=ruleset_name settings to
> # apply (must be mounted already, i.e. fstab(5))
> devfs_load_rulesets="NO" # Enable to always load the default rulesets
> -performance_cx_lowest="HIGH" # Online CPU idle state
> -performance_cpu_freq="NONE" # Online CPU frequency
> -economy_cx_lowest="HIGH" # Offline CPU idle state
> -economy_cpu_freq="NONE" # Offline CPU frequency
> +performance_cx_lowest="HIGH" # AC Online CPU idle state
> +performance_cpu_freq="NONE" # AC Online CPU frequency
> +economy_cx_lowest="HIGH" # AC Offline CPU idle state
> +economy_cpu_freq="NONE" # AC Offline CPU frequency
> virecover_enable="YES" # Perform housekeeping for the vi(1) editor
> ugidfw_enable="NO" # Load mac_bsdextended(4) rules on boot
> bsdextended_script="/etc/rc.bsdextended" # Default mac_bsdextended(4)
>
> Also, I noticed that when changing economy_cx_lowest, the indentation
> of the comment changed, should I add a couple spaces after the closing
> quote to keep the comment aligned?
No. Just like in the kernel conf, the appropriate format is:
option<space><tab>*# comment
(Also just like in the kernel conf, this rule is frequently ignored/abused)
Doug
--
I am only one, but I am one. I cannot do everything, but I can do
something. And I will not let what I cannot do interfere with what
I can do.
-- Edward Everett Hale, (1822 - 1909)
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-rc
To unsubscribe, send any mail to "[email protected]"
