Maksim Yevmenkin wrote: > Please find attached patch that adds new option to the PPP. > > run-scripts-in-direct-mode > Default: Disabled. This allows to run chat scripts in > direct mode. > > did i miss anything? objections? comments? reviews?
First comment: run it past Brian Somers <[EMAIL PROTECTED]>; it's his baby, and he's the active maintainer. Rest of comments: Actually, why doesn't "-direct" allow a chat script by default? The man page doesn't document that as a side-effect of "-direct", only of "-dedicated", but it's been there since the import. Should this really be a "negotiate" section command, rather than just a command or a "set" command? Also, there are only two other commands even have a "-" in them, and both of them only have one (just seems a little long, compared to, say, "rsid" or "direct-with-script", or even "force-script"). Personal preference: don't make it conditional on "-direct", let it also work with "-dedicated", and call it "force-script" or something, instead. The man page should be updated -- including the undocumented side-effect of "-direct" disabling scripts). -- Terry To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-questions" in the body of the message
