https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251412
Rainer Hurling <rhur...@freebsd.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rhur...@freebsd.org
--- Comment #3 from Rainer Hurling <rhur...@freebsd.org> ---
Hi,
Many thanks for the patch.
There two issues with your patch (test with 'portlint -AC'):
- Don't remove PORTEPOCH, once it exists [1]
- Your files/patch-setup.py is not generated by 'make makepatch'. For a proper
patch format it is recommended to use 'make makepatch' [2]
[1] Section 5.2.3.2 from Porters Handbook
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html
[2] Section 4.4 from Porters Handbook
Another thought:
The hint in pkg-message about two additional ports is only visible when the
port is installed.
Wouldn't it be useful from the user's point of view to include these two ports
math/py-statsmodels and devel/py-xarray as RUN_DEPENDS in the Makefile? I would
expect a much better user experience.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
