https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241565

Kubilay Kocak <ko...@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needs-patch

--- Comment #9 from Kubilay Kocak <ko...@freebsd.org> ---
Minor review items:

1) Match COMMENT to setup.py:description (modulo portlint compliance)
2) Package has tests shipped with it. Add TEST_DEPENDS and (do-)test target for
better QA accordingly. Ask upstream to package tox.ini and declare
tests_require=pytest in setup.py so it makes figuring out how to run tests
quicker/easier for downstream consumers (packages *and* users).

The above changes don't require maintainer approval (ports (python) compliance)

@Kyle This needs QA confirmation (including maketest: after (2)) to progress.
To assist with the test target, for pytest, the usual caonical and
deterministic invocation command is: 

do-test:
    @cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -v -rs -o addopts=

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

Reply via email to