https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241966
Kubilay Kocak <ko...@freebsd.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://github.com/pandas-d
| |ev/pandas/issues/949,
| |https://github.com/flupke/p
| |ypotrace/issues/14,
| |https://bugzilla.kernel.org
| |/show_bug.cgi?id=204231
--- Comment #2 from Kubilay Kocak <ko...@freebsd.org> ---
Review items:
- Remove PORTREVISION when updating PORTVERSION/DISTVERSION
- DISTNAME not required (defaults to PORTNAME-DISTVERSION)
- setup.py:version specifies the version is 2.2 (should be 2.8 per
PORTVERSION).
- Does not require gmake to build: package provides a setup.py utilising
setuptools Extension class to build.
- Built extension is not stripped: Warning:
'lib/python2.7/site-packages/generate.so' is not stripped consider trying
INSTALL_TARGET=install-strip or using ${STRIP_CMD} (use $STRIP_CMD} in a
post-install: target)
- URL [1] declared in setup.py is Forbidden
- LICENSE is not defined in port, or setup.py. Some license(s) should be
declared so they can be reflected acurately in the port. Could not find license
details on homepage URL or in sources, except the following:
- expr.c: from NetBSD (Public Domain)
- generate.c: This program may be freely distributed as long as ... (also in
other files)
- getline.c # This code may be used on any computer system for ...
- USES=python does not specify a :<version-spec> of supported versions, which
allows builds on any (every) Python version. generate fails to import on Python
3: ImportError: /usr/local/lib/python3.7/site-packages/generate.so: Undefined
symbol "PyString_FromString" [2][3][4]
- Add Trove Classifiers to setup.py to declare what versions are supported
- Set setup.py:python_requires to suite
- Specify USES=python:<version-spec> to match above.
- A simple test suite / tests for generate would be great for future QA
[1] http://www.druid.net/darcy/readme-generate.html
[2] https://github.com/pandas-dev/pandas/issues/949
[3] https://github.com/flupke/pypotrace/issues/14
[4] https://bugzilla.kernel.org/show_bug.cgi?id=204231
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
