https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240375
--- Comment #4 from Kubilay Kocak <ko...@freebsd.org> ---
(In reply to René Thümmler from comment #3)
My pleasure René, you're welcome & very nice work
A few nits:
- No need for a PORTREVISION for a new (not yet committed port)
- misaka has a max version pin, one must either declare that, or patch it out.
misaka>=2.0<3.0 should work
- Upstream specifies ==2.7 as the environment marker, so match that (instead of
(PYTHON_REL < 3000) where possible. In these "==" cases, one can use
<flavor>_RUN_DEPENDS helpers, like: py27_RUN_DEPENDS= foo \ bar
- I'd use ${ETCDIR} rather than ${PREFIX}/etc in post-patch (it covers more of
the path), unless it makes the REINPLACE search/replace 'too' challenging or
less readable. Likewise for post-install (use ETCDIR)
- For sqlite3, does this actually need the "sqlite module in Python" ? If so,
depend on databases/py-sqlite3 directly (we split that module out from the
stdlib/language ports). If this is the case, remove sqlite:3 from USES
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
