https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238007

Kubilay Kocak <ko...@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open
           Keywords|                            |needs-patch, needs-qa
            Summary|New port:                   |[NEW PORT]
                   |sysutils/py-leviathan,      |sysutils/py-leviathan:
                   |control utility for         |Application to control and
                   |NZXT/Asetek liquid coolers  |monitor NZXT (Asetek)
                   |                            |liquid coolers
                 CC|                            |greg@unrelenting.technology
                   |                            |, pyt...@freebsd.org
              Flags|                            |maintainer-feedback?(greg@u
                   |                            |nrelenting.technology)

--- Comment #1 from Kubilay Kocak <ko...@freebsd.org> ---
Thank you for contributing a new port Greg

Review items:

 - Python packages that install scripts (this one does) should be made
concurrent safe. Use USE_PYTHON=concurrent for this, which handles most files
automatically.

 - Port does not specify USES=python:<version-spec>, which (implicitly)
declares support for any Python version, but it is unclear what versions this
package supports. In particular, if this package only supports Python 2 or 3
*only*, <version-spec> must be declared accordingly

Upstream (https://github.com/jaksi/leviathan/blob/0.1.1/README.md) suggest
using pip3 leviathan which implies it supports Python 3, but it is unclear if
it *requires* Python 3. Please confirm

 - Confirm this port passes QA (portlint, poudriere in particular) for all
Python (major) versions it supports.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

Reply via email to