https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235701
--- Comment #8 from Tobias Kortkamp <to...@freebsd.org> --- Comment on attachment 201984 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=201984 svn-diff-alternate 1. MAN should be named MANPAGES as it usually is. 2. The new options and helpers are badly ordered [1]. 3. Remove .include <bsd.port.options.mk> again and use options helpers targets. 4. This should probably be post-build-MAN-on (or post-build-MANPAGES-on after fixing the option name): +pre-install: 5. gmake is not declared as a build dependency, so this will probably fail: + ${LOCALBASE}/bin/gmake -C ${WRKSRC}/docs man 6. Use the INSTALL_MAN macro to install files into STAGEDIR, not CP. [2] 7. What does this do and why does it require gsed? + ${SED_CMD} -i '1i\.if n .pl 2000v' ${STAGEDIR}${PREFIX}/man/man7/certbot.7 If the input for creating certbot.7 is already broken can it not be fixed instead? 8. Why is patch-docs_conf.py needed? [1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html [2] https://www.freebsd.org/doc/en/books/porters-handbook/install.html -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ freebsd-python@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
