https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226290
Kubilay Kocak <ko...@freebsd.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|New |Open
Flags| |maintainer-feedback?(dereks
| |@lifeofadishwasher.com)
Keywords| |feature, needs-patch,
| |needs-qa
CC| |der...@lifeofadishwasher.co
| |m, ko...@freebsd.org,
| |pyt...@freebsd.org
--- Comment #2 from Kubilay Kocak <ko...@freebsd.org> ---
Thank you for your new port contribution
Review item(s):
- Default to MASTER_SITES=CHEESESHOP for packages that are distributed/released
there. Use alternative sources (Eg: GitHub) only if there is a (temporary)
compelling case to use them, eg if important test or data files have not been
correctly included in the source distribution (sdist). Submit upstream PR's
issues in these cases
- Use the verbatim upstream setup.py:description/short_description where
possible, modified to comply with portlint if necessary. "Interact with GitLab
API". Submit upstream issues/pr's where the description should/could be
improved.
- Add TEST_DEPENDS and a test target where available (even if they cannot be
automatically run without user intervention)
- Packages that support multiple python versions that also provide console
scripts [this one does [1]), must be concurrent safe (ie;
USE_PYTHON=concurrent added, and QA'd with multiple python versions, confirmed
not to produce conflicting filenames)
[1] https://github.com/python-gitlab/python-gitlab/blob/master/setup.py#L26
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
