https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221090

Kubilay Kocak <ko...@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |maintainer-feedback?(freebs
                   |                            |d...@skinc.ru)
                 CC|                            |pyt...@freebsd.org
           Keywords|                            |feature, needs-patch,
                   |                            |needs-qa
             Status|New                         |Open

--- Comment #1 from Kubilay Kocak <ko...@freebsd.org> ---
Thank you Ilia. Some review items:

- Prefer MASTER_SITES=CHEESESHOP by default (unless important files missing
from PyPI sdist). Remove USE_GITHUB/GH_* accordingly.
- setup.py (and PyPI) says version is lib_version = "1.3.13" (plus "post3"
suffix). Consider using DISTVERSION=1.3.13.post3 to match
- cython is listed in both setup.py: setup_requires and install_requires. this
makes it both a BUILD_DEPENDS and a RUN_DEPENDS (the latter is missing).
- setup.py:description is "A python wrapper for the ENet library". Set COMMENT
to match (minus leading "A", for portlint compliance)

Please also confirm this port passes poudriere QA if possible. For more
information and instructions, see:
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

Reply via email to