https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193314
--- Comment #6 from Jingfeng Yan <yan_jingf...@yahoo.com> ---
(In reply to Kubilay Kocak from comment #2)
> Thanks for your submission Jingfen.
>
> Review items:
>
> * Leftover commented out items
> * DISTNAME unnecessary
Removed.
> * LICENSE and LICENSE_FILE need values
License provided.
> * Use ${PYTHON_PKGNAMEPREFIX}<name> for python RUN_DEPENDS checks unless
> they are
> for binaries.
> * GH_PROJECT defaults to ${PORTNAME} already
Fixed.
> * The github repository has git tags, use them over direct to commit hashes
> when
> they're available
By using tag name, the WRKDIR try to use tag, but by default it is use commit
id.
> * pkg-descr only contains a hash value, please create a proper pkg-descr
Fixed.
>
> Additionally,
>
> Run your port through portlint -AC, and attach portlint output for this and
> future submissions.
provided.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-python@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
