On Thu, Oct 1, 2020 at 4:12 PM Moritz Schmitt <mor...@schmi.tt> wrote: > > Hi, > > I recently took over my first maintainership of a port and I have a > question regarding on how to deal with compiler warnings. > > The port is devel/cscope and it seems to be in a rather good shape. It > contains the newest version of cscope and it builds without any major > problems. However, when building it the compiler issues three warnings > that I could easily patch away. > > What's the recommended approach? Just ignore the warnings and don't > modify the software since it builds anyway? Or create patches even > though they don't seem to be strictly necessary? > > In any case, I will send the patches to the project in the hope that > they fix it upstream in the long run. >
This is kind of your prerogative as the maintainer to do whatever you feel is right. Personally, I would usually not bother patching the port if I can easily send it upstream and they don't look like actual functional/security issues, *unless* I'm doing a version update anyways that would cause folks to rebuild the port -- then I might tack them on at the same time just so I can later point to the port and say "Hey, we've been running with these and everything is (fine / on fire)!" In any event, +1 for sending them upstream regardless. :-) _______________________________________________ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
