On Fri, Jun 16, 2017 at 05:07:30PM +0200, Mathieu Arnold wrote: > Le 16/06/2017 à 16:43, Steve Kargl a écrit : > > On Fri, Jun 16, 2017 at 02:17:03PM +0200, Mathieu Arnold wrote: > >> Le 16/06/2017 à 01:45, Steve Kargl a écrit : > >>> Is this the expected behavior? > >>> > >>> % cd ports/math/octave > >>> % make fetch > >>> octave-4.0.3_5: Makefile error: "1.7+" is not a valid value for > >>> JAVA_VERSION. It should be one or more of: 1.6 1.7 1.8 (with an optional > >>> "+" suffix.) > >>> % grep JAVA_VERSION Makefile > >>> JAVA_VERSION= 1.7+ > >> > >> Not really. What OSVERSION are you running? > >> > >> What is the content of the _JAVA_VERSION_LIST and > >> _JAVA_VERSION_LIST_REGEXP variables ? > >> > > I'm running a month old freebsd-current. > > > > % uname -a > > FreeBSD troutmask.apl.washington.edu 12.0-CURRENT FreeBSD 12.0-CURRENT > > #0 r318546: Fri May 19 12:51:04 PDT 2017 > > > > % cd /usr/ports/math/octave > > % make -d v fetch |& grep JAVA_VERSION > > $ make -V _JAVA_VERSION_LIST > 1.6 1.7 1.8 1.6+ 1.7+ 1.8+ > $ make -V _JAVA_VERSION_LIST_REGEXP > 1.6\|1.7\|1.8\|1.6+\|1.7+\|1.8+ > > You should get the same as me. I wonder if it is not a difference in how > grep behaves on 12 where it does not match 1.7+ with the regexp in there. >
Yes, it appears to be a grep issue. In Mk/bsd.java.mk, I removed the @ in line 227 to see what the test did. I then try to reproduce just the part with grep (without the -q option) at a Bourne shell prompt. # echo "1.7+" 1.7+ # echo "1.7+" | /usr/bin/tr " " "\n" 1.7+ # echo "1.7+" | /usr/bin/tr " " "\n" | /usr/bin/grep "1.6\|1.7\|1.8\|1.6+\|1.7+\|1.8+" # So, nothing is returned. If I reduce the regex pattern, I see # echo "1.7+" | /usr/bin/tr " " "\n" | /usr/bin/grep "1.7+" 1.7+ -- Steve 20170425 https://www.youtube.com/watch?v=VWUpyCsUKR4 20161221 https://www.youtube.com/watch?v=IbCHE-hONow _______________________________________________ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
