On 1 Apr, Bryan Drewery wrote: > On 4/1/2015 2:13 AM, Don Lewis wrote: >> On 1 Apr, Bryan Drewery wrote: >>> On 4/1/2015 1:54 AM, Don Lewis wrote: >>>> I'm working on a couple of new ports where I'm using fetching the >>>> distfiles from github. One quirk is that the tags start with a prefix >>>> of "tags/v". I'm setting PKGNAMEPREFIX=${PYTHON_PKGNAMEPREFIX}. > > Wow it really has 'tags/' in the tags and 'branches/' in the branches. > It has to be a bad conversion from SVN. Anyway it is intended to be > supported fine...
Yeah, trying to get "make fetch" working was quite entertaining. >>>> >>>> If I follow the example for in the Porters Handbook using >>>> DISTVERSIONPREFIX=tags/v then the distfile gets named >>>> ${PORTNAME}-tags/v${PORTVERSION}_GH0.tar.gz, >>>> which seems somewhat undesirable. This seems to be a bit misleading >>>> and risky because this port is just a python wrapper around another >>>> library that also has the same PORTNAME. That port hasn't been >>>> converted to fetch from github, and when it does it seems like there >>>> would be a chance of collisions. >>>> >>>> I seem to get better results by setting GH_TAGNAME=tags/v${PORTVERSION}. >>>> In that case, the distfile gets named >>>> ${GH_ACCOUNT}-${GH_PROJECT}-${PORTVERSION}-tags-v${PORTVERSION}_GH0.tar.gz. >>>> This seems to be excessively verbose, but safer. > > Just use GH_TAGNAME=tags/v${PORTVERSION} for now. Ok, will do. > The DISTVERSIONPREFIX is supposed to work in this case as well. I'll > look into it tomorrow. > > It is likely the same as > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199069 which I > realized earlier today. > > The DISTNAME you see is intentionally verbose so it is unique and avoids > rerolled checksums on account/project renames or PORTVERSION changes or > github-specific rerolls. It is intended to stand out as a > GITHUB-generated file so it is not confused with other distributed files. > > The DISTVERSIONPREFIX _not_ producing the same filename is a bug. Thanks! _______________________________________________ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"