On 3/25/15 9:50 AM, Bryan Drewery wrote:
On 3/24/2015 5:32 AM, Marcus von Appen wrote:
Julian Elischer <jul...@freebsd.org>:
[...]
esac | ${PATCH} ${PATCH_DIST_ARGS} `patch_dist_strip $$i` ; \
done )
.endif
+.if defined(EXTRA_PATCH_TREE)
[...]
+.endif
.if defined(EXTRA_PATCHES)
@set -e ; \
for i in ${EXTRA_PATCHES}; do \
============
Nice. I'd however change the patch behaviour to the following:
- patch-* from FreeBSD
- EXTRA_PATCHES from FreeBSD
- local patches
Your patch looks like it appleis the out-of-tree patches prior
to any EXTRA_PATCHES defined by the port itself. This should not be
the case, in my opinion. Locally managed patches should always come
last to ensure that all FreeBSD/maintainer-specific bits have been
applied and the local changes are just added on top of those.
Cheers
Marcus
Agreed. The local patches are intended to avoid touching the port. If
they are not last then you may have to go tweaking some of the other
ports patches to fix your own.
that makes sense.. it just means shifting the code down a bit..
_______________________________________________
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
