Re: Options: ${opt}_CPPFLAGS?

[Baptiste Daroussin]

On Tue, Sep 24, 2013 at 09:18:08PM +0200, Christian Weisgerber wrote:
> Baptiste Daroussin:
> 
> > > | If X_ABOVEVARIABLE is defined then its value will be appended to
> > > | ABOVEVARIABLE depending on the status of the option X
> > > 
> > > ... which agrees with bsd.options.mk.  But shouldn't this also
> > > include CPPFLAGS?
> > 
> > Good idea, patch welcome :)
> 
> Index: bsd.options.mk
> ===================================================================
> --- bsd.options.mk    (revision 328190)
> +++ bsd.options.mk    (working copy)
> @@ -93,9 +93,9 @@
>  # ${opt}_CMAKE_OFF                   When option is disabled, it will add 
> its content to
>  #                                                    the CMAKE_ARGS.
>  #
> -# For each of CFLAGS CXXFLAGS LDFLAGS CONFIGURE_ENV MAKE_ENV USES DISTFILES,
> -# defining ${opt}_${variable} will add it to the actual variable when the
> -# option is enabled.
> +# For each of CFLAGS CPPFLAGS CXXFLAGS LDFLAGS CONFIGURE_ENV MAKE_ENV USES
> +# DISTFILES, defining ${opt}_${variable} will add it to the actual variable
> +# when the option is enabled.
>  #
>  # For each of the depends target PKG EXTRACT PATCH FETCH BUILD LIB RUN,
>  # defining ${opt}_${deptype}_DEPENDS will add it to the actual dependency 
> when
> @@ -392,7 +392,7 @@
>  .    if defined(${opt}_CMAKE_ON)
>  CMAKE_ARGS+= ${${opt}_CMAKE_ON}
>  .    endif
> -.    for flags in CFLAGS CXXFLAGS LDFLAGS CONFIGURE_ENV MAKE_ENV USES 
> DISTFILES
> +.    for flags in CFLAGS CPPFLAGS CXXFLAGS LDFLAGS CONFIGURE_ENV MAKE_ENV 
> USES DISTFILES
>  .      if defined(${opt}_${flags})
>  ${flags}+=   ${${opt}_${flags}}
>  .      endif
> 
> -- 
> Christian "naddy" Weisgerber                          na...@mips.inka.de

Approves please co mit

regards,
Bapt

pgp5OCe507_r1.pgp
Description: PGP signature