On Mon, Jun 04, 2012 at 08:03:50AM +0200, Baptiste Daroussin wrote:
> On Sun, Jun 03, 2012 at 04:28:16PM -0700, Doug Barton wrote:
> > My understanding is that one of the benefits of the new OPTIONS
> > framework is that it's supposed to take make.conf knobs into account
> > when displaying the options dialog.
>
> yes it is if you use the new way of setting KNOBS aka a general:
> OPTIONS_UNSET= NLS
>
> WITHOUT_NLS is not triggered as a compatibility from bsd.options.mk to
> OPTIONS_UNSET= NLS while NOPORTDOCS and NOPORTEXAMPLES are.
>
> >
> > I have WITHOUT_NLS defined in make.conf, but when I started an upgrade
> > today for x11-toolkits/libxfce4gui the dialog came up with all options
> > chosen (DOCS, NLS, STARTUP) even though I have the make.conf knob, and
> > the following in the existing options file:
> >
> > _OPTIONS_READ=libxfce4gui-4.8.1
> > WITHOUT_NLS=true
> > WITH_STARTUP=true
> > WITH_GLADEUI=true
> > WITHOUT_APIDOCS=true
>
> if you have an existing options file then the priority is set to what is in
> that
> options file.
>
> The priority is set that way:
> 1/ the options from the bsd.options.mk if any
> 2/ the default options chosen by the maintainer
> 3/ the options set in make.conf (OPTIONS_SET/OPTIONS_UNSET)
> 4/ the options set per port in make.conf
> (${UNIQUENAME}_SET/${UNIQUENAME}_UNSET)
> 5/ the options from the options file with 2 way of loading: them:
> - the old one figuring out the informations WITH_/WITHOUT_
> - the new one: just hit ok on the dialog and have a look at the file it has
> changed.
>
> >
> > The fact that the STARTUP option is still enabled is fine, although I
> > suspect it's probably a side effect. The fact that the other 2 options
> > are showing as enabled is a bug. In the case of NLS, it's likely at
> > least 2 different bugs.
>
> In my mind the NLS case is a single bug, the loading of old saved optionfile
> which doesn't work as expected. I'll have a look, thanks for reporting
>
>
> > FWIW, this showed up using portmaster, which runs 'make
> > config-conditional' by default.
> >
> > Doug
> >
>
> regards,
> Baptbtw the new options framework only reads and convert the WITHOUT/WITH stuff from optionsfile in case the old option framework is still in used in the ports. Which is no more the case libxfce4gui. I am open to suggestions here on how to do better things here. regards, Bapt
pgpokNQDcF6oc.pgp
Description: PGP signature
