On Fri, Mar 16, 2012 at 5:49 AM, b. f. <bf1...@googlemail.com> wrote: > Jeremy Messenger wrote: >> On Thu, Mar 15, 2012 at 6:23 PM, Chuck Swiger <cswiger at mac.com> wrote: >> > On Mar 15, 2012, at 4:18 PM, Jeremy Messenger wrote: >> >> Figured out. Add custom CFLAGS in the make.conf and you will get a >> >> build failure with make but not gmake. Here's what I have in my >> >> make.conf: >> >> >> >> CFLAGS= -O2 -fno-strict-aliasing -pipe -g >> >> STRIP= >> > >> > Does it work properly if you use "CFLAGS+=" instead? >> >> It will, but you do not need to put '+' in make.conf. I have same >> CFLAGS for years and years, btw. > > If you have been making these assignments unconditionally, then for > years and years you have been in danger of breaking or damaging the > builds for many ports that explicitly invoke make(1) more than once > (and thus read make.conf more than once), by clobbering prior changes > to CFLAGS or STRIP that are made in port makefiles. Despite the > misleading examples in the base-system example make.conf, this kind of > customization is not supported for Ports, and not encouraged. You > should take steps to ensure that your custom values are set only once, > before any top-level port Makefile is parsed. You can define them > conditionally, or move them to another makefile that is included only > once, or disable multiple inclusions of make.conf for Ports by using > something like "__MAKE_CONF=/dev/null" in the right place.
Any ports have to respect the CFLAGS, see the porter handbook. If it fails to do then it needs to be fixed. Add '+' in the make.conf is not right way to do it as it's merely add in exists CFLAGS. mandree, thanks for took care of it! Cheers, Mezz > b. -- mezz.free...@gmail.com - m...@freebsd.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gn...@freebsd.org _______________________________________________ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
