On 18/02/2012 00:01, Doug Barton wrote:
> On 02/17/2012 15:41, Mikhail T. wrote:
>> If, in fact, the current port does not care, which version of libfoo is
>> uses -- and most software does not -- then declaring an explicit V is
>> wrong: it /gratuitously/ tightens the build-time requirements. Unless a
>> particular version is, indeed, required, the above line should read simply:
>>
>> LIB_DEPENDS= foo:${PORTSDIR}/cat/libfoo
>
> Big +1. Same goes for how some of the build/run deps are specified. This
> has definitely become a case of "If you give someone a knob, it's
> overwhelmingly likely that they will twist it."
How about the attached?
Cheers,
Matthew
--
Dr Matthew J Seaman MA, D.Phil.
PGP: http://www.infracaninophile.co.uk/pgpkey
Index: src/portlint.pl
===================================================================
RCS file: /home/ncvs/ports/ports-mgmt/portlint/src/portlint.pl,v
retrieving revision 1.125
diff -u -u -r1.125 portlint.pl
--- src/portlint.pl 27 Dec 2011 01:26:34 -0000 1.125
+++ src/portlint.pl 18 Feb 2012 10:08:27 -0000
@@ -1330,6 +1330,13 @@
"found in
\${PORTSDIR}/Mk/bsd.apache.mk.");
}
+ # Check for over-specific shared library dependencies
+ if ( $j eq 'LIB_DEPENDS' && $m{'dep'} =~ m/(\.\d+$)/ ) {
+ &perror("WARN", $file, -1, "$j don't specify
the " .
+ "ABI version number $1 in $m{dep}
unless it is " .
+ "really necessary.");
+ }
+
# check port dir existence
$k = $m{'dir'};
$k =~ s/\${PORTSDIR}/$ENV{'PORTSDIR'}/;
signature.asc
Description: OpenPGP digital signature
