On 22/11/2011 17:29, Jason Helfman wrote: > On Tue, Nov 22, 2011 at 10:49:24AM -0500, Wesley Shields thus spake: >> On Tue, Nov 22, 2011 at 03:44:47PM +0000, Matthew Seaman wrote: >>> On 22/11/2011 13:29, Wesley Shields wrote: >>> > On Mon, Nov 21, 2011 at 12:42:59AM -0500, Eitan Adler wrote: >>> >> On Sun, Nov 20, 2011 at 10:18 AM, Eitan Adler >>> <li...@eitanadler.com> wrote: >>> >>> On Sun, Nov 20, 2011 at 4:45 AM, Matthew Seaman >>> >>> <m.sea...@infracaninophile.co.uk> wrote: >>> >>>> >>> >>>> PORT_DBDIR?= /var/db/ports is the default setting in >>> bsd.ports.mk -- the >>> >>>> following ports redefine it to exactly the same value: >>> >>>> [ snip ] >>> >>> >>> >>> Thanks for the report - I'll handle these. >>> >> >>> >> Sorry for the empty promise. Something came up and I won't have the >>> >> time to look at these :( - maybe someone else can take them up >>> > >>> > Hi Matthew! >>> > >>> > If you could please file these in a PR and CC me I will try and work >>> > through all of these. >>> >>> Done: http://www.freebsd.org/cgi/query-pr.cgi?pr=162754 >> >> Thank you! I will try and clean all this up, but as I'm sure you're >> aware we are coming up on a holiday in the states so my time is limited >> for the next few days. I will look at this as time permits though! >> >> -- WXS > > I did have a brief look at some of these and it was a great catch. One item > I did find interesting is a number of these define LATEST_LINK, but it just > matches ${PORTNAME}, so the LATEST_LINK can more than likely be dropped > -- on > a case-by-case basis, of course.
Yes -- in fact, all the ports where PORT_DBDIR was redefined also set
OPTIONSFILE to what would be the default value in any case. About half
the ports mentioned were essentially clones of one of the
phpX-extensions ports or borrowed heavily from them.
I did a bit of checking to see if there were any other common cases with
OPTIONSFILE but couldn't find anything obvious. Haven't searched for
people setting LATEST_LINK to what would be the default in any case.
Hmmm... just by inspection, there's a lot of ports that essentially set
LATEST_LINK to ${PKGNAMEPREFIX}${PORTNAME}${PKGNAMESUFFIX} -- and that
is actually the default value already. I'll stick looking into that on
the queue.
Cheers,
Matthew
--
Dr Matthew J Seaman MA, D.Phil. 7 Priory Courtyard
Flat 3
PGP: http://www.infracaninophile.co.uk/pgpkey Ramsgate
JID: matt...@infracaninophile.co.uk Kent, CT11 9PW
signature.asc
Description: OpenPGP digital signature
