Hi David Many many thanks for your patch. I'll test it very soon.
Just one comment > I believe openoffice-2* can me marked as SAFE while openoffice-3* should not > be marked at all (since it sometimes works..., very well for me :-). you can mark as SAFE for all of our ports. If it's broken, its OOo issue. We should identify if dependencies are missing. -devel ports can be unsafe but 3, 3-RC 2, 2-RC must be safe. Please wait a few days to say ok. Best, From: David Naylor <naylor.b.da...@gmail.com> Subject: Re: MAKE_JOBS_UNSAFE (some more ports) Date: Sat, 23 May 2009 11:01:56 +0200 > On Friday 22 May 2009 15:41:38 Ion-Mihai Tetcu wrote: >> On Fri, 22 May 2009 19:53:50 +0900 (JST) >> >> Maho NAKATA <cha...@mac.com> wrote: >> > In massive parallel build, OOo can be broken. We explicitly >> > fix them otherwise broken. I just test with MAXJOB = 4 or something >> > like that. >> > >> > > I had it complain about perl (or >> > > something) needing to be recompiled but that was because I >> > > interrupted the build process. It has always completed for me when >> > > using MAX* from the start. >> > >> > me too. but - note it just works for you. >> > >> > > I can make the patch, only thing is bsd.port.mk will need to be >> > > patched (simple enough though). >> >> I can run a few test builds on QAT and maybe Phillip can do the same on >> his tindy. Just drop us the patch ;-) >> Even if it only works with MAXJOB = 2, we mark it as such and the build >> will be faster. > > Please see attached for the patch. The changes to bsd.port.mk: > - MAKE_JOBS_NUMBER always defined > - MAKE_JOBS_NUMBER forced to 1 if UNSAFE of DISABLE > - MAKE_JOBS_NUMBER defaults (but user defined) to number of cores > > I've then used MAKE_JOBS_NUMBER to set MAXPROCESSES, MAXMODULES and > NUMOFPROCESSES for openoffice-* (not including 1.*). > > I believe openoffice-2* can me marked as SAFE while openoffice-3* should not > be marked at all (since it sometimes works..., very well for me :-). > > This patch just makes openoffice-* behave like other ports in regards to > parallel builds and the usual MAKE_JOBS variables now works as expected. > > Happy testing, > > David
pgpq2xMEndG96.pgp
Description: PGP signature
