On Wed, Dec 06, 2006 at 10:19:06PM +0800, LI Xin wrote:
> Marc G. Fournier wrote:
> > 
> > 'k, I don't know how to fix this one ... I thought about doing:
> > 
> > .if ${OSVERSION} <= 492101
> > RUN_DEPENDS=    nc:${PORTSDIR}/net/netcat
> > .endif
> > 
> > not sure which version brought in nc, but 492101 is the last of the 4.x 
> > series 
> > ... but it portlint fails miserably if I don't put bsd.port.pre.mk before 
> > it, 
> > but also fails if I do:
> > 
> > WARN: Makefile: no MASTER_SITES found. is it ok?
> > WARN: Makefile: "RUN_DEPENDS" has to appear earlier.
> > 0 fatal errors and 2 warnings found.
> > 
> > Is there a better way of doing this ... ?
> 
> I think you want something like:
> 
> .if ${OSVERSION} < 503102 || (${OSVERSION} >= 600000 && ${OSVERSION} <
> 600010)
> 
> instead of just considering 492101.

That's a good suggestion.

Mark, as to the portlint problem - well, portlint cannot really be
expected to handle each and every corner case in a port Makefile :)
It is doing a wonderful job as it is, but every now and then you have
to make a choice between a working port and a clean port ;)

To make the OSVERSION check work, you do indeed need a bsd.port.pre.mk
inclusion before it.  Then... just ignore the portlint warnings.

And... thanks for a great utility! :)

G'luck,
Peter

-- 
Peter Pentchev  [EMAIL PROTECTED]    [EMAIL PROTECTED]    [EMAIL PROTECTED]
PGP key:        http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint FDBA FD79 C26F 3C51 C95E  DF9E ED18 B68D 1619 4553
I am the meaning of this sentence.

Attachment: pgpgfGwBpJiKC.pgp
Description: PGP signature

Reply via email to