On Tue, Dec 05, 2006 at 08:40:49PM -0500, Wesley Shields wrote: > On Tue, Dec 05, 2006 at 05:08:45PM -0800, Ade Lovett wrote: > > > > On Dec 05, 2006, at 13:59 , Doug Barton wrote: > > > > >Wesley Shields wrote: > > >>>@comment DISTFILE:$filename:$size:$md5:$sha256 > > > > > >I think that's good, the other information might come in handy down > > >the road. One thing you might want to consider is to put the md5 sum > > >at the end, since at some point down the road (maybe years from now, > > >but still ...) we're likely to drop md5 altogether. > > > > Better still would be: > > > > @comment DISTFILE:<filename>[':' <key>=<value>]* > > > > eg: DISTFILE:foo:SIZE=1234:MD5=...:SHA256=... > > > > Relying on the specific position of an item in a delimited list > > almost always comes back and bites in painful spots later on down the > > way. Minimal extra parsing required by consumers, and bits and > > pieces can be added/removed almost at will. > > > > -aDe > > I agree. I'll modify Doug's latest patch to add this.
I've reworked the two patches to take all of the suggestions in. Part 1 (the pkg_info piece): - Silently ignores the -F flag when distfile information is not recorded in +CONTENTS. - Prints the information out in a human readable format (still respects -q). Part 2 (the bsd.port.mk piece) is the patch posted by Doug with Ade's suggestions. The entire thing no longer requires a change to pkg_create in order to function. Anymore thoughts/comments/ideas before I send-pr these? http://www.atarininja.org/~wxs/patches/package-distinfo-part1.diff http://www.atarininja.org/~wxs/patches/package-distinfo-part2.diff -- WXS _______________________________________________ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "[EMAIL PROTECTED]"
