> On Jan 15, 2025, at 4:31 AM, Gleb Smirnoff <gleb...@freebsd.org> wrote: > > On Tue, Jan 14, 2025 at 07:25:26PM +0800, Zhenlei Huang wrote: > Z> I just fixed one long standing bug of sppp(4) [1]. During the testing I > found ng_sppp(4) depends on this module. Unfortunately sppp(4) is only > enabled on i386 and amd64 by default but ng_sppp(4) is enabled on all > architectures. So on architectures other than i386 and amd64 `kldload > ng_sppp` will never succeed. > Z> > Z> I suppose sppp(4) is rarely used nowadays so I'm planing to conditionally > build ng_sppp(4) only on i386 and amd64. Is there still real usage of sppp(4) > on other architectures ? > Z> > Z> 1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=173002 > > I would claim there is no usage of neither sppp(4) nor ng_sppp(4) on any > architecture in a very long term. Last time I run this kind of network > framing > in 2004 and in that times the right way to do it was either pure negraph(4) > graph based on ng_cisco(4) or ports/net/mpd + ng_ppp(4). > > Don't waste your time on this code.
This is a quick simple fix. Committed as https://cgit.freebsd.org/src/commit/?h=stable/13&id=29f77be0d844aa7e9b26fed8b550e12ad504b4d2 <https://cgit.freebsd.org/src/commit/?h=stable/13&id=29f77be0d844aa7e9b26fed8b550e12ad504b4d2> . > > -- > Gleb Smirnoff
