vmaffione accepted this revision.
vmaffione added a comment.
This revision is now accepted and ready to land.


  Looks good, thanks.
  The netmap unit tests and integration tests still pass with these changes.
  
  As a side, using the netmap emulated adapter (aka generic) is rather slow, 
because of the translation layer between the netmap buffers and the mbufs. The 
right way to let netmap interact with VLANs would be to implement the VLAN 
strip/push operations in your netmap application, and always open physical 
ports (e.g. ix0). I know this is hard to do here, because the VALE switch is 
not easy to extend in kernel-space. In theory VALE could be ported to 
userspace, so that you can easily add custom logic for VLAN handling.

CHANGES SINCE LAST ACTION
  https://reviews.freebsd.org/D20824/new/

REVISION DETAIL
  https://reviews.freebsd.org/D20824

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: aleksandr.fedorov_itglobal.com, vmaffione, jhb, bz
Cc: olevole_olevole.ru, krion, evgueni.gavrilov_itglobal.com, freebsd-net-list
_______________________________________________
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

Reply via email to