I think that sounds right; but Adrian is the one who put the code in the #ifdef RSS blocks in. We don't have it enabled/defined in our testing here.
- Eric On Sun, Sep 10, 2017 at 8:01 PM Sepherosa Ziehau <sepher...@gmail.com> wrote: > Hi all, > > I am on the way to cleanup the UDP_IPV4_EX bit. The only effective > consumer of this undefined RSS hash type is ixl. > > So I took a bit close look at it, then I have several question about > its hash type configuration: > > ixl_set_rss_pctypes(). It tries to set hash for IPV6 fragment, if > RSS_IPV6_EX is set for "options RSS". RSS_IPV6_EX never meant IPV6 > fragments: > > https://docs.microsoft.com/en-us/windows-hardware/drivers/network/rss-hashing-types#ndishashipv6ex > > ixl_ptype_to_hash(). As far as I understand, the decoded.outer_frag > means "outer packet header indicates a fragment", which has nothing to > do with the any of the IPV6_EX related bits: > > https://docs.microsoft.com/en-us/windows-hardware/drivers/network/rss-hashing-types > > I believe these all should be fixed. > > Thanks, > sephe > > -- > Tomorrow Will Never Die > _______________________________________________ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
