On Sat, 22 Jul 2017 12:11:31 +0300
"Andrey V. Elsukov" <bu7c...@yandex.ru> wrote:
> Freeing mbuf is under pfil hook responsibility, if it returns nonzero
> value it must call m_freem(). So, it is bug in the ndpacket.c.
Ah, thanks for clarifying this. It was quite unclear to me, because at
other place I've seen m_freem() is called after non-zero pfil_run_hooks()
result. [1]
Nevertheless, I've patched and tested ndproxy as you suggested, and it
works fine, with no mbuf leaks. Pull request created. [2]
Thank you once again for looking at this.
--
Dan
[1] https://github.com/freebsd/freebsd/blob/master/sys/netinet/ip_fastfwd.c#L232
[2] https://github.com/AlexandreFenyo/ndproxy/pull/3
_______________________________________________
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
