Yes. Actually, we would also need one beteween the following two options: 1) Implementing a dummy if_start() for if_loop.c 2) Prevent netmap from using if_loop.
Cheers, Vincenzo 2017-07-11 22:05 GMT+02:00 Marius Strobl <mar...@freebsd.org>: > On Thu, Jul 06, 2017 at 02:19:42PM -0700, Vincenzo Maffione wrote: > > Sure, can anyone commit this? > > The addition of KASSERTs like the below one to if_handoff() and > if_start()? Sure. > > Marius > > > > > Il 5 lug 2017 4:05 AM, "Marius Strobl" <mar...@freebsd.org> ha scritto: > > > > > On Mon, Jul 03, 2017 at 05:08:09PM +0200, Vincenzo Maffione wrote: > > > > Details here: > > > > > > > > https://github.com/luigirizzo/netmap/issues/322 > > > > > > > > Is it acceptable to commit the proposed patch? > > > > > > As suggested by hselasky@, the outliner problem at hand is better > solved > > > by a dummy if_start method in order to not hurt the fast-path. Thus, if > > > anything at all, a KASSERT(ifp->if_start != NULL, "no if_start method") > > > should be added to if_handoff() and if_start(). > > > > -- Vincenzo Maffione _______________________________________________ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
