decui_microsoft.com added inline comments. INLINE COMMENTS
> David_A_Bright_DELL.com wrote in if_var.h:407 > I would stick with the previous "ifup/ifdown" or go with "Interface up/down". > I think "Interface up/ifdown" reads poorly. I was trying to keep the consistency with Line 392, 395, 401 and 404. I would tend to leave the patch as it is, if you won't strongly object to it. :-) > David_A_Bright_DELL.com wrote in if_var.h:408 > It would be nice to have the 0/1 values for these two defines line up. In any > case, it definitely seems like there is extraneous whitespace between > "IFNET_EVENT_UP" and "0". Actually the 2 lines do line up. The visual confusion is due to the nasty Tab issue in the case of a patch. :-) With "set list" in my Vim, the lines of the file net/if_var.h (rather than the patch with a leading + at the beginning of the lines) shows #define IFNET_EVENT_UP^I^I0$ #define IFNET_EVENT_DOWN^I1$ ^I means a Tab. $ means a CR-LF. REVISION DETAIL https://reviews.freebsd.org/D9345 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: decui_microsoft.com, hselasky, sepherosa_gmail.com, cem, np, kmacy, kib, honzhan_microsoft.com, howard0su_gmail.com, jhb, ae, delphij, royger, glebius, gnn, rwatson Cc: David_A_Bright_DELL.com, freebsd-net-list _______________________________________________ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
