Sorry Rick, what's the small change you wanted in sys/netinet/tcp_output.c at 777-778? I see it's calc'ing length... or did you want me to take the whole file back to 9.1-RELEASE ?
On Thu, Mar 20, 2014 at 11:47 PM, Rick Macklem <rmack...@uoguelph.ca> wrote: > Christopher Forgeron wrote: > > Yes, there is something broken in TSO for sure, as disabling it > > allows me > > to run without error. It is possible that the drop in performance is > > allowing me to stay under a critical threshold for the problem, but > > I'd > > feel happier testing to make sure. > > > > I understand what you're asking for in the patch, I'll make the edits > > tomorrow and recompile a test kernel and see. > > > I also suggested a small change (basically reverting it to the 9.1 code) > for tcp_output() in sys/netinet/tcp_output.c (around line# 777-778). > You might as well throw that in at the same time. > > Thanks for all your work with this (and this applies to others that > have been working on this as well.) > > rick > > > Right now I'm running tests on the ixgbe that Jack sent. Even if his > > patch > > fixes the issue, I wonder if something else isn't broken in TSO, as > > the > > ixgbe code has had these lines for a long time, and it's only on this > > 10.0 > > build that I have issues. > > > > I'll be following up tomorrow with info on either outcome. > > > > Thanks for your help.. your rusty networking is still better than > > mine. :-) > > > > > > On Thu, Mar 20, 2014 at 11:13 PM, Rick Macklem <rmack...@uoguelph.ca> > > wrote: > > > > > Christopher Forgeron wrote: > > > > > > > > Output from the patch you gave me (I have screens of it.. let me > > > > know > > > > what you're hoping to see. > > > > > > > > > > > > Mar 20 16:37:22 SAN0 kernel: after mbcnt=33 pklen=65538 > > > > actl=65538 > > > > Mar 20 16:37:22 SAN0 kernel: before pklen=65538 actl=65538 > > > Hmm. I think this means that the loop that generates TSO segments > > > in > > > tcp_output() is broken, since I'm pretty sure that the maximum size > > > should be is IP_MAXPACKET (65535). > > > > > > Either that or some non-TCP socket is trying to send a packet that > > > exceeds IP_MAXPACKET for some reason. > > > > > > Would it be possible to add a printf() for m->m_pkthdr.csum_flags > > > to the before case, in the "if" that generates the before printf? > > > I didn't think to put this in, but CSUM_TSO will be set if it > > > is a TSO segment, I think? My networking is very rusty. > > > (If how to add this isn't obvious, just email and I'll update > > > the patch.) > > > > > > Thanks for doing this, rick > > > > > > > > _______________________________________________ > > freebsd-net@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-net > > To unsubscribe, send any mail to > > "freebsd-net-unsubscr...@freebsd.org" > > > _______________________________________________ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
