On Sun, 20 Jan 2013 10:56:24 +1100
Peter Jeremy <pe...@rulingia.com> wrote:

> On 2013-Jan-17 14:38:06 -0500, "Stephen J. Kiernan" <ste...@juniper.net> 
> wrote:
> >The patch also includes moving zlib.[ch] and zlibutil.h out of net and 
> >into sys/libkern (for the .c) and sys/sys (for the .h).
> 
> Good.
> 
> >It really doesn't make much sense for that code to live in net, 
> >especially when so many things which are not the network stack utilize 
> >it.
> 
> One thing that currently doesn't is ZFS - which has its own copy.  It
> would be nice if ZFS could use the common copy.

I'll take a look at that.

> 
> >Is that going to be a problem? Should simple stubs be added in the 
> >original locations in net/ to include the one in sys/ now?
> 
> IMHO, no.  zlib wasn't an advertised API so nothing outside the base
> OS should be using it.  If you've moved all the kernel code to use
> the new location, that should be enough.

Okay, then I won't worry about adding ones.

Thanks.

--
Stephen J. Kiernan
Juniper Networks, Inc.
stevek_at_juniper.net

Attachment: signature.asc
Description: PGP signature

Reply via email to