On Sun, 16 Jan 2011, Marius Strobl wrote:
Hi,
On Fri, Jan 14, 2011 at 01:41:09PM +0300, Lev Serebryakov wrote:
Hello, Marius.
You wrote 14 ?????? 2011 ?., 4:24:12:
found by ignoring the bits set in the "don't care mask". I've
updated the patch at the above URL accordingly and based on my
testing it now should actually work as expected. Sorry for the
glitch.
Yes, it works for me.
Thanks for testing! I've committed the patch to HEAD and will try
to get it into 7.4 and 8.2.
Only one note: I think, it is good idea to document this flag in
re(4).
Technically re.4 obviously is the wrong location for documenting it
as it's generally the business of the PHY drivers to handle the media.
Moreover, rgephy(4) driven PHYs are also commonly used in combination
with at least axe(4), nfe(4), nve(4) and sge(4) MACs so we would have
to document this special media option in all of the corresponding man
pages, which would introduce undesirable redundancy. So instead I've
added a rgephy.4 man page and documented it there.
Actually, this is a very good example for why we generally should not
document media types and options in the man pages of MAC drivers that
take advantage of mii(4) but instead add a common ifmedia.4 and just
point there and if as in this case it makes sense to man pages of
specific PHY drivers.
First of all, thanks a lot for the work! Can you email me the entire
set of revisions off-list so that I could have a look, especially to
see if we can still sneak things into the release after the RC2s (or
send them to re@ fore pre-review and I'll read them there;)
Second, I start to like the idea of <$phy>.4 in addition to <$mac>.4 man
pages and .Xrs given our discussion lately on the extra alias options.
The only drawback I see is that the ifconfig.8 -> <$mac>.4 -> <$phy>.4
man page chain gets longer and ifconfig generally doesn't reference
any drivers but miibus.4 does. Would it make a sense to add a list of
man pages of the `phys' implementing miibus in addition to the list of
drivers making use of miibus, rather than just having adding the .Xr
at the end? The list might grow in the future now that it was
started?
/bz
--
Bjoern A. Zeeb You have to have visions!
<ks> Going to jail sucks -- <bz> All my daemons like it!
http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/jails.html
_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
