On 31 Mar 2010, at 18:06, Bernhard Schmidt wrote: > On Wed, Mar 31, 2010 at 03:05:27PM +0100, Rui Paulo wrote: >> On 31 Mar 2010, at 15:04, Bernhard Schmidt wrote: >> >>> On Wed, Mar 31, 2010 at 02:31:30PM +0100, Rui Paulo wrote: >>>> On 31 Mar 2010, at 14:24, Antoine Brodin wrote: >>>>> This looks great! >>>>> Is there specific reasons to use pointers and not ints for some >>>>> arguments of foo_tx_complete() and foo_tx_update()? >>>> >>>> Not really. I'll probably switch them to ints at some point. >>> >>> Hmm, I somehow like the idea of not passing integers here. Looking at >>> ath_rate/sample it passes a struct. I don't know whether this can be >>> rewritten though. >> >> It can be rewritten to pass ints, from what I understand. > > Ok great, looks fine to me. > > Do you intend to commit this in one huge chunk (quite a few drivers > affected) or create a branch for that?
I wanted people to comment on the general framework. I wasn't planning on creating a branch, because I didn't feel it was necessary. Porting AMRR code to this framework isn't hard and I can deal with any fallout. -- Rui Paulo _______________________________________________ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
