-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Jack and all,

Few month before I've send a PR (see bellow) about interrupt setup in
em driver.
Now I run into the same problem with igb too. It seems that I'm the
one using such an old interrupt mechanism with new chips...

So the problem is that when one tries to register legacy mode
interrupts, NULL is passed to bus_setup_intr as handler.

Jack: Please check my attached path and apply it if you think so.

Original PR was the following:
Number:140728
Category:kern
Synopsis:[em] [patch] Fast irq registration in em driver

Have a nice day,
Tibor
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iD8DBQFLXW9QCwkLbqzjZAIRApe6AJ9310xDauVwNFsDd9cq5GYop2GlzwCg2y5T
v54NC8n6XeAlg0VhB+jDaHE=
=vSx/
-----END PGP SIGNATURE-----

Index: if_igb.c
===================================================================
--- if_igb.c	(revision 202964)
+++ if_igb.c	(working copy)
@@ -2075,7 +2075,7 @@
 	taskqueue_start_threads(&adapter->tq, 1, PI_NET, "%s taskq",
 	    device_get_nameunit(adapter->dev));
 	if ((error = bus_setup_intr(dev, adapter->res,
-	    INTR_TYPE_NET | INTR_MPSAFE, igb_irq_fast, NULL,
+	    INTR_TYPE_NET | INTR_MPSAFE, NULL, igb_irq_fast,
 	    adapter, &adapter->tag)) != 0) {
 		device_printf(dev, "Failed to register fast interrupt "
 			    "handler: %d\n", error);
Index: if_em.c
===================================================================
--- if_em.c	(revision 202964)
+++ if_em.c	(working copy)
@@ -2787,7 +2787,7 @@
 	    INTR_TYPE_NET | INTR_FAST, em_irq_fast, adapter,
 #else
 	if ((error = bus_setup_intr(dev, adapter->res[0],
-	    INTR_TYPE_NET, em_irq_fast, NULL, adapter,
+	    INTR_TYPE_NET, NULL, em_irq_fast, adapter,
 #endif
 	    &adapter->tag[0])) != 0) {
 		device_printf(dev, "Failed to register fast interrupt "

Attachment: legacy-intr.patch.sig
Description: PGP signature

_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

Reply via email to