On Friday 30 May 2008 11:45:32 Julian Elischer wrote:
> Rajkumar S wrote:
> > On Sat, May 24, 2008 at 6:09 AM, Julian Elischer <[EMAIL PROTECTED]> 
wrote:
> >> subject says it all really..
> >
> > I am using pf and rtable to setfib and get an pfctl: DIOCADDRULE:
> > Device busy when trying to load "pass in quick on fxp0 from any to
> > any keep state rtable 1"
>
> I'm not really familiar with the pf syntax
> as I didn't do that part of the patch (max laier (CC'd) did)
> and I don't use pf.
>
> Max may be able to see if the patch to the pf code ahs an error.

See attached - stupid error, my bad.  Confirmed to work now, with limited 
testing, though.

-- 
/"\  Best regards,                      | [EMAIL PROTECTED]
\ /  Max Laier                          | ICQ #67774661
 X   http://pf4freebsd.love2party.net/  | [EMAIL PROTECTED]
/ \  ASCII Ribbon Campaign              | Against HTML Mail and News
--- Begin Message ---
Author: mlaier
Date: Thu Jun  5 19:30:20 2008
New Revision: 179570
URL: http://svn.freebsd.org/changeset/base/179570

Log:
Fix range check for rtable id.

Modified:
   head/sys/contrib/pf/net/pf_ioctl.c

Modified: head/sys/contrib/pf/net/pf_ioctl.c
==============================================================================
--- head/sys/contrib/pf/net/pf_ioctl.c  Thu Jun  5 19:01:31 2008        
(r179569)
+++ head/sys/contrib/pf/net/pf_ioctl.c  Thu Jun  5 19:30:20 2008        
(r179570)
@@ -1532,7 +1532,7 @@
                }
 
 #ifdef __FreeBSD__ /* ROUTEING */
-               if (rule->rtableid > 0 && rule->rtableid < rt_numfibs)
+               if (rule->rtableid > 0 && rule->rtableid > rt_numfibs)
 #else
                if (rule->rtableid > 0 && !rtable_exists(rule->rtableid))
 #endif
@@ -1795,7 +1795,7 @@
 
                        if (newrule->rtableid > 0 &&
 #ifdef __FreeBSD__ /* ROUTING */
-                           newrule->rtableid < rt_numfibs)
+                           newrule->rtableid > rt_numfibs)
 #else
                            !rtable_exists(newrule->rtableid))
 #endif


--- End Message ---
_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "[EMAIL PROTECTED]"

Reply via email to