On Tue, Jul 03, 2007 at 10:27:07AM -0500, David DeSimone wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > W Forms <[EMAIL PROTECTED]> wrote: > > > > I don't really understand this, since from what I can see all that > > Pyun YongHyeon's changes do is replacing a constant value of 6 and 8 > > with macros containing the value of 6 and 8. > > Here's the patch as I recall it: > > > - sc->rl_eewidth = 6; > + sc->rl_eewidth = RL_9356_ADDR_LEN; > re_read_eeprom(sc, (caddr_t)&re_did, 0, 1); > if (re_did != 0x8129) > - sc->rl_eewidth = 8; > + sc->rl_eewidth = RL_9346_ADDR_LEN; > > /* 9346 EEPROM commands */ > +#define RL_9346_ADDR_LEN 6 /* 93C46 1K: 128x16 */ > +#define RL_9356_ADDR_LEN 8 /* 93C56 2K: 256x16 */ > > It looks to me like 6 was replaced with 8, and vice versa. In other > words, a real bug fix. :) >
Yep. Previously it tried to probe 93C46 EEPROM first. Now it probes 93C56 before going back to 93C46. I'll ask for re approval to commit. Thanks for testing and report! -- Regards, Pyun YongHyeon _______________________________________________ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "[EMAIL PROTECTED]"
