Max Laier wrote:


I'm not sure if you are mistaking Yar for me here. As for my concerns - consider them withdrawn. I still don't like the idea that the code in net*inet*/ip_fw2.c gets to know about VLAN internals, but if everybody feels that it does belong there - fine. I hereby resign from this thread.


In the latest patch it doesn't..
The only knowledge of vlans is added to if_bridge.c and bridge.c (in 6.x)

Anyway, I hope everybody is having happy holidays.

not bad..


If what you are suggesting is that we pass into ipfw an 'offset'
into the packet as well as the packet, then yes I like that idea,
but I didn't see Andre suggest it.

I can however submit another patch that does that..

However I'd like to hear from you a response to the mail
I sent you with a pure cleanup patch that removes mopst occurrances
of mtod() from ipfw.. if you did not get that email I can resend it
to you.

you are right max.. I sent the email to you not Yar..

it was just a cleanup patch.


There is also work in progress to introduce nested VLANs AKA Q-n-Q.
They seem to present a challenge to the scheme you are implementing.
not a permanent problem.. it could be modified to handle it.
but I'll take it into account in the next version if
you think it is a required feature.. what is the maximum
nesting level?


_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "[EMAIL PROTECTED]"

Reply via email to