On Saturday 04 February 2006 16:16, Max Laier wrote: > On Thursday 02 February 2006 14:37, Max Laier wrote: > > On Thursday 02 February 2006 13:43, Yar Tikhiy wrote: > > > > This needs to be fixed in pf then. > > > > > > Max Laier and I discussed this issue once, and Max had concern > > > over possible performance degradation that might result from > > > calling pflog functions through pointers to be set by a separate > > > pflog module. We can skip touching the pf module in RELENG_6 for > > > now and leave the issue to after 6.1-RELEASE is out. > > > > I have convinced myself that we should really use a function pointer > > here. I will try to commit a sollution to HEAD over the weekend. If you > > are MFC'ing the changes *now*, I'd appreciate if you could spare out pf, > > but I am willing to MFC the changes before 6.1 if testing goes well. > > Here it is. I'd appreciate feedback. pflog_packet() uses a lot of complex > types which makes it necessary to include pfvar.h. This is ugly, but I > don't know how to work around this.
FYI, just committed this to the tree. -- /"\ Best regards, | [EMAIL PROTECTED] \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | [EMAIL PROTECTED] / \ ASCII Ribbon Campaign | Against HTML Mail and News
pgpxj59fJeT0b.pgp
Description: PGP signature
