Hello!
by this specific implementation. I'm sure we can keep an interface that
handles priorities as seperate interfaces, but I'm not sure we'll want
to do it via the vlan device (attractivly simple though that is.)
This patch appears to be against 4 or 5. In 6 we've largly rewritten
ifconfig so the patch won't apply. It looks like a simple matter to fix
this issue. We'll need to commit to 6 before 4 or 5.
I've embeded some comments in the text below.
Ok, so what I should do now? Rewrite patch for 6?
+ if(tag < 1 || tag > 4094)
+ errx(1, "VLAN ID shoud be in range 1..4094");
errx should be fully indented.
What this means? What difference between my errx and this one (from 6)?
errx(1, "must specify both vlan tag and device");
I know other nearby code does this, but atoi should not be used. It has
not useful error checking. strtoul should be used instead.
No problem.
*/
struct vlanreq {
- char vlr_parent[IFNAMSIZ];
- u_short vlr_tag;
+ char vlr_parent[IFNAMSIZ];
+ u_int16_t vlr_tag;
This appears to be a no-op. Is it needed?
Hmm... just to clarify that vlr_tag is 16bit value. If this is
unnecessary I may use u_short.
--
With respect,
Boris
_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "[EMAIL PROTECTED]"
