On Fri, Nov 14, 2003 at 10:53:55AM -0800, John Polstra wrote: > On 14-Nov-2003 Brooks Davis wrote: > > > > I think is should work, but performance may be poor. Currently, > > vlan_input() finds the correct vlan by searching the list of all vlans > > until it finds the correct one. For that many vlans, it might be > > necessicary to modify the code to use some form of balanced tree instead > > of a simple list. This should be fairly straight forward to fix. > > Why not simply index directly into an array of 4096 pointers? Anybody > running that many VLANs can afford the extra 16 kB per physical > interface.
I suggested the balanced tree because we've got two implementations in sys/tree.h, but you are correct that the space probably isn't worth the overhead of the trees. You'd have to use per physical interface trees anyway, so that part would be the same. -- Brooks -- Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4
pgp00000.pgp
Description: PGP signature
