On Sun, Feb 24, 2002 at 10:47:02AM +0200, Ruslan Ermilov wrote: > On Sat, Feb 23, 2002 at 07:25:20AM -0800, Crist J. Clark wrote:
[snip] > > If you are correct, and you can cross interfaces, this is a much > > bigger problem. I didn't mention it in your first mail, but the > > in_broadcast() function as used in the patch you sent is different > > than the current implementation. in_broadacast() currently takes an > > address and an interface. If you are correct, we'd have to loop > > through the interface list... which makes this uglier. > > > No, I can't cross interfaces, /* Check for broadcast addresses. */ > in ip_input() doesn't allow this. Exactly, I found that code early on. I had considered possibly dropping all TCP right then and there, but decided that was not the right place to do it. > I'm talking about a different > scenario here, multiple IP networks per interface: > > host# netstat -rn -finet | grep -w default > default 192.168.4.65 UGSc 4 387 rl0 > > gateway# ifconfig fxp0 inet > fxp0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> mtu 1500 > inet 192.168.4.65 netmask 0xffffff00 broadcast 192.168.4.255 > inet 192.168.100.1 netmask 0xffffff00 broadcast 192.168.100.255 Right. But to me, that seems at best suboptimal and at worst slightly misconfigured. A host shouldn't be routing traffic over one interface. This is the kind of route that will generate ICMP redirects. But none of this really has anything to do with the problem. I am going to test the final revision I made after reviewing the patches you presented earlier in this thread and then make the commit. -- Crist J. Clark | [EMAIL PROTECTED] | [EMAIL PROTECTED] http://people.freebsd.org/~cjc/ | [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-net" in the body of the message