On Fri, Oct 26, 2001 at 01:28:29PM +0100, Ian Dowse wrote:
> In message <[EMAIL PROTECTED]>, David Malone writes:
> >
> >So the M_LEADINGSPACE macro should probaly read:
> >
> >#define M_LEADINGSPACE(m)
> > \
> > (!M_WRITABLE(m) ? 0 : \
> > (m)->m_flags & M_EXT ? (m)->m_data - (m)->m_ext.ext_buf : \
> > (m)->m_flags & M_PKTHDR ? (m)->m_data - (m)->m_pktdat : \
> > (m)->m_data - (m)->m_dat)
>
> Yes, I think this is cleaner than the version that was just committed
> to -stable, and it could have been committed to -current and MFC'd
> in the normal way without changes. I really doubt that it is worth
> splitting up M_WRITABLE just to marginally optimise M_LEADINGSPACE.
gcc -O seems to agree with you :)
This form produces a kernel which is 32 bytes shorter than
the form that I committed (out of 1Meg, so not really a big deal).
cheers
luigi
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-net" in the body of the message
