I'd be happy to see a KASSERT() dropped in there--the type of bug this is
probably intended to address is a reversed set of procedures during
interface cleanup, or multiple invocation. In SMPng, the failure modes
for this kind of error situation will be a lot less forgiving (especially
with regards to potential races), and as such we want to find those
failures early, rather than let them slip through.
Robert N M Watson FreeBSD Core Team, TrustedBSD Project
[EMAIL PROTECTED] NAI Labs, Safeport Network Services
On Sun, 23 Sep 2001, Matthew N. Dodd wrote:
> sys/net/if.c and bpf.c have problems with if_detach() and
> bpfdetach() when they are called with a struct ifnet that has not had
> if_attach() and bpfattach() called on it. Null pointer reference ->
> *boom* etc.
>
> This patch fixes the test already present in bpfdetach() and adds a test
> to if_detach().
>
> Thanks.
>
> --
> | Matthew N. Dodd | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD |
> | [EMAIL PROTECTED] | 2 x '84 Volvo 245DL | ix86,sparc,pmax |
> | http://www.jurai.net/~winter | For Great Justice! | ISO8802.5 4ever |
>
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-net" in the body of the message
