On Thu, Dec 21, 2000 at 03:36:52PM -0800, Don Lewis wrote:
> On Dec 20, 3:51pm, Jesper Skriver wrote:
> } > We should also bail out if the sequence check fails,
> } > since it isn't possible for there to be another connection with the same
> } > src/srcport/dst/dstport, so there is no sense in continuing the search.
> }
> } That is was we do right ?
> }
> } First we check if src/dst ip address and port numbers match, if not we
> } bail out, so if we reach the above check we know these match, then we
> } check for tcp sequence number, if this doesn't match we bail out.
>
> If the src/dst addresses and port numbers don't match, we start the next
> iteration of the loop. If the sequence numbers don't match, we want to
> exit the loop. I believe the continue should be changed to a break.
Agree, a minor change I'll get PHK to put into the diff he's about to
commit.
> I'll pretty much be off the net until the new year, so I won't be able
> to perform any further reviews until then.
Happy new year and a merry Xmas.
/Jesper
--
Jesper Skriver, jesper(at)skriver(dot)dk - CCIE #5456
Work: Network manager @ AS3292 (Tele Danmark DataNetworks)
Private: Geek @ AS2109 (A much smaller network ;-)
One Unix to rule them all, One Resolver to find them,
One IP to bring them all and in the zone to bind them.
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-net" in the body of the message
