jhell schrieb am 2010-03-02:

> On Mon, 1 Mar 2010 14:52, alexbestms@ wrote:

> >oh. and btw: wouldn't it be reasonable to prevent a user shooting
> >himself in
> >the foot if he has the brilliant idea of setting "MAKEOBJDIRPREFIX
> >= /" ?

> >alex


> Trying to match something like this is going to get out of control.
> Though this is a nice idea but why should a user be prevented from
> doing such things ?.

> Boiling down these are not variables that usually have to be changed
> and if they are changed the user has done a little bit of research
> and is more advanced than most and recognizes that / is not a option.

hmmm...so you think something like this won't be useful?

alex

> --

> jhell
Index: Makefile
===================================================================
--- Makefile    (revision 204540)
+++ Makefile    (working copy)
@@ -112,6 +112,9 @@
 .error MAKEOBJDIRPREFIX can only be set in environment, not as a global\
        (in make.conf(5)) or command-line variable.
 .endif
+.if ${MAKEOBJDIRPREFIX} == "/"
+.error MAKEOBJDIRPREFIX musn't point to the root directory.   
+.endif
 MAKEPATH=      ${MAKEOBJDIRPREFIX}${.CURDIR}/make.${MACHINE}
 BINMAKE= \
        `if [ -x ${MAKEPATH}/make ]; then echo ${MAKEPATH}/make; else echo 
${MAKE}; fi` \
_______________________________________________
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "freebsd-hackers-unsubscr...@freebsd.org"

Reply via email to