Hi, On Wed, Oct 21, 2009 at 3:11 AM, Max Laier <m...@love2party.net> wrote: > On Monday 19 October 2009 16:08:06 Rink Springer wrote: >> Hi Ivan, >> >> On Mon, Oct 19, 2009 at 03:52:30PM +0200, Ivan Voras wrote: >> > if nobody objects, I'll commit it :) >> >> I seem to recall that setproctitle() is quite expensive to call; perhaps >> it would make sense offer a flag to prevent make(1) from calling it? [1] > > Just rate-limit the setproctitle() call to once/sec or once/percentage-step > and be done with it.
Rather try to setproctitle() in the same make process every second with a one second initial delay (so that short lived make processes won't be bogged down by this expensive call). And preferentially do the timing check after returning from exec() of a child make. This way the stats won't be "perturbed" by the short lived make's and only one make process will call setproctitle() at any time (except when running "make -j" ?). > > I must say that trying it out on a kernel build didn't proof too useful as the > targets have vastly different runtimes, but I think it's a good addition > nonetheless. So please, go for it Ivan. > If you implement it, please use a control mechanism like, say, an environment variable MAKE_TRACK_PROGRESS, which, for performance and POLA sake, might default to disabled (including when environment is not defined). My 5cents, Adrian Penisoara EnterpriseBSD.com _______________________________________________ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to "freebsd-hackers-unsubscr...@freebsd.org"
