Re: devctl (alike?) for devfs

[Andriy Gapon]

on 13/05/2008 22:16 Kostik Belousov said the following:

I looked at your previous patch, and it seems it is much simpler to
do drop the devmtx once more then to try to abuse free lists.

In the destroy_devl(), after the

        while (dev->si_threadcount != 0) {
                /* Use unique dummy wait ident */
                msleep(&csw, &devmtx, PRIBIO, "devdrn", hz / 10);
        }

loop, add

        mtx_unlock(&devmtx);
        if (!cold)
                devctl_notify("DEVFS", dev->si_name, "DESTROY", NULL);
        mtx_lock(&devmtx);

Thank you again! This is simply perfect.


--
Andriy Gapon

diff --git a/sys/kern/kern_conf.c b/sys/kern/kern_conf.c
index 1db25f8..f90e469 100644
--- a/sys/kern/kern_conf.c
+++ b/sys/kern/kern_conf.c
@@ -30,6 +30,7 @@ __FBSDID("$FreeBSD$");
 #include <sys/param.h>
 #include <sys/kernel.h>
 #include <sys/systm.h>
+#include <sys/bus.h>
 #include <sys/bio.h>
 #include <sys/lock.h>
 #include <sys/mutex.h>
@@ -706,6 +707,10 @@ make_dev_credv(int flags, struct cdevsw *devsw, int 
minornr,
        devfs_create(dev);
        clean_unrhdrl(devfs_inos);
        dev_unlock_and_free();
+
+       if (!cold)
+               devctl_notify("DEVFS", dev->si_name, "CREATE", NULL);
+
        return (dev);
 }
 
@@ -794,6 +799,10 @@ make_dev_alias(struct cdev *pdev, const char *fmt, ...)
        clean_unrhdrl(devfs_inos);
        dev_unlock();
        dev_depends(pdev, dev);
+
+       if (!cold)
+               devctl_notify("DEVFS", dev->si_name, "CREATE", NULL);
+
        return (dev);
 }
 
@@ -842,6 +851,12 @@ destroy_devl(struct cdev *dev)
                msleep(&csw, &devmtx, PRIBIO, "devdrn", hz / 10);
        }
 
+       if (!cold) {
+               mtx_unlock(&devmtx);
+               devctl_notify("DEVFS", dev->si_name, "DESTROY", NULL);
+               mtx_lock(&devmtx);
+       }
+
        dev->si_drv1 = 0;
        dev->si_drv2 = 0;
        bzero(&dev->__si_u, sizeof(dev->__si_u));

_______________________________________________
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "[EMAIL PROTECTED]"