Hi Ruslan,

On Fri, Oct 20, 2006 at 11:13:32PM +0400, Ruslan Ermilov wrote:
> On Fri, Oct 20, 2006 at 05:08:48PM +0200, Jeremie Le Hen wrote:
> > Hi,
> > 
> > src.conf(5) manual page states:
> > 
> > % The src.conf file contains settings that will apply to every build
> > % involving the FreeBSD source tree; see build(7).
> > % ...
> > % The only purpose of src.conf is to control the compilation of the FreeBSD
> > % sources, which are usually found in /usr/src.
> > 
> > However, share/mk/bsd.port.mk includes <bsd.own.mk> which in turn includes
> > /etc/src.conf.  Therefore if I have some WITH_/WITHOUT_ knob in it
> > which affects CFLAGS, they will be taken into account even for port builds.
> > 
> > Is it the expected behaviour ?  Maybe WITH(OUT)_ should simply avoid
> > modifying CFLAGS (though I think this might become useful in the near
> > future).
> > 
> See if the attached patch helps.  If it does, I'll commit.  I've
> never heard back on this patch after I sent it to [EMAIL PROTECTED]

This patch works correctly.  Would you explain me why assigning
/dev/null to _SRCCONF don't work in the current version of bsd.port.mk ?

Also, your patch avoids performing the WITH(OUT)_* stuff for ports in
order to prevent from polluting the namespace.  If there is to be
some WITH(OUT)_* knobs which leads to CFLAGS modification in the future
(I'm thinking about ProPolice with the upcoming GCC 4.1), wouldn't it
be worth benefiting this framework for ports ?

Thank you.
Regards,
-- 
Jeremie Le Hen
< jeremie at le-hen dot org >< ttz at chchile dot org >
_______________________________________________
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "[EMAIL PROTECTED]"

Reply via email to